portlint

--mandir=${PREFIX}
---++defined(WITHOUT
dir/
gratuitious ()
legal portversion
cd kkk/dirabc&&copytree_share \s* nnn/dirabc => cd kkk&&copytree_share dirabc nnn/
detect unneeded for loops somehow
"cp -r" => "cp -R"
chown in Makefile => chown in plist (for dirs)
trailing slashes in plist
plist: empty dirs check
plist: dir not-in-mtree check
:= in depends is legal
bdeps=${rdeps} => bdeps:=${rdeps} if right after rdeps=something
s/.sh// in use_rc_subr
non-ascii everywhere
more than one consecutive blank lines everywhere
trailing whitespace everywhere
more bsd.sites.mk checks
target consolidation: pre-x+do-x+post-x=>do-x
dupes in _ARGS, _LIST, _ENV, etc.
unroll simple for loops: only one command with only one iterator instance
distname/wrksrc should be based on distversion
distversionprefix/suffix where appropriate
don't += non-user-tunables outside of loops (only first time they turn up in a Makefile)
proper indentation, esp. continuation lines
@FreeBSD.org
shell built-in's vs. separate commands
sig in pkg-descr
portname in comment
make variable defs in targets
rerolled distfiles
freebsd.org/local in master sites
category vs current subdir